[Sherpa] Update Sherpa to 2.2.16 and add Recola #10200

shimashimarin · 2025-11-16T23:18:48Z

Update Sherpa to v2.2.16, which include a bugfix of Enhance_Factor.
Add Recola1 for 1-Loop Amplitudes computation and interface to Sherpa. Recola1 could helps on Sherpa NLO diboson simulation.
Clean/update some patch files.

cmsbuild · 2025-11-16T23:19:16Z

A new Pull Request was created by @shimashimarin for branch IB/CMSSW_16_0_X/master.

@akritkbehera, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

cmsbuild · 2025-11-16T23:19:16Z

cms-bot internal usage

smuzaffar · 2025-11-17T08:41:42Z

please test

smuzaffar · 2025-11-17T10:48:09Z

recola.spec

+mkdir %{i}/cmake
+cp %{i}/lib/cmake/recolaConfig.cmake %{i}/cmake
+sed -i 's;^.*set(RECOLA_LIBRARY_DIR.*$;get_filename_component(RECOLA_LIBRARY_DIR "${CMAKE_CURRENT_LIST_DIR}/../lib" ABSOLUTE);' %{i}/cmake/recolaConfig.cmake
+sed -i 's;^.*set(RECOLA_INCLUDE_DIR.*$;get_filename_component(RECOLA_INCLUDE_DIR "${CMAKE_CURRENT_LIST_DIR}/../include" ABSOLUTE);' %{i}/cmake/recolaConfig.cmake


@shimashimarin , you are copying %{i}/lib/cmake/recolaConfig.cmake in to %{i}/cmake ? is this needed? I would suggest to leave the cmake files lib/cmake path and run sed command directly on %{i}/lib/cmake/recolaConfig.cmake. If you really want cmake files in top level directory then please delete the one from %{i}/lib/cmake

@shimashimarin , can you please take care of it. As expected , we see build paths in lib/cmake files https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0817e1/49482/external_checks/relocate/recola.txt

lib/cmake/recolaConfig.cmake:set(RECOLA_LIBRARY_DIR "/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/BUILDROOT/6e292a6c44125ef340634bfdd66fa7ea/opt/cmssw/el8_amd64_gcc13/external/recola/1.5.0-6e292a6c44125ef340634bfdd66fa7ea/lib") lib/cmake/recolaConfig.cmake:set(RECOLA_INCLUDE_DIR "/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/BUILDROOT/6e292a6c44125ef340634bfdd66fa7ea/opt/cmssw/el8_amd64_gcc13/external/recola/1.5.0-6e292a6c44125ef340634bfdd66fa7ea/include")

Thanks for pointing out this. I have updated it

cmsbuild · 2025-11-17T10:54:04Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0817e1/49482/summary.html
COMMIT: 45dee59
CMSSW: CMSSW_16_0_X_2025-11-16-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/10200/49482/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 15 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 6 differences found in the comparisons
Reco comparison had 2 failed jobs
DQMHistoTests: Total files compared: 51
DQMHistoTests: Total histograms compared: 3896448
DQMHistoTests: Total failures: 8
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3896420
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
Checked 218 log files, 188 edm output root files, 51 DQM output files
TriggerResults: no differences found

cmsbuild · 2025-11-17T11:18:44Z

Pull request #10200 was updated.

smuzaffar · 2025-11-17T12:00:01Z

please test

cmsbuild · 2025-11-17T14:18:40Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0817e1/49494/summary.html
COMMIT: df2229b
CMSSW: CMSSW_16_0_X_2025-11-16-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmsdist/10200/49494/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

@pallabidas Updating EMTF NN to v1.0.1 #10191

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0817e1/49494/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0817e1/49494/git-merge-result

Comparison Summary

Summary:

You potentially added 59 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 6 differences found in the comparisons
Reco comparison had 2 failed jobs
DQMHistoTests: Total files compared: 51
DQMHistoTests: Total histograms compared: 3896448
DQMHistoTests: Total failures: 15323
DQMHistoTests: Total nulls: 10
DQMHistoTests: Total successes: 3881095
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
Checked 218 log files, 188 edm output root files, 51 DQM output files
TriggerResults: found differences in 4 / 49 workflows

smuzaffar · 2025-11-17T14:35:06Z

DQMHistoTests: Total failures: 15323

these differences are due to EMTF update

shimashimarin · 2025-11-17T14:46:06Z

Hi @smuzaffar, may I backport updates to versions CMSSW_14_X and CMSSW_15_X? These updates should be helpful for some Run3 sample production

smuzaffar · 2025-11-17T14:49:11Z

sure, if these changes are need there then feel free to open PRs for earlier release cycles.

makortel · 2025-11-17T15:20:15Z

hold

I want to have a discussion about Recola privately.

cmsbuild · 2025-11-17T15:20:42Z

Pull request has been put on hold by @makortel
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

shimashimarin added 4 commits November 16, 2025 11:28

add recola

357cbb7

add cmake config of collier.spec

30db943

add collierConfigVersion.cmake

e6fb775

add recola to sherpa

45dee59

cmsbuild added tests-pending externals-pending pending-signatures orp-pending labels Nov 16, 2025

cmsbuild added tests-started and removed tests-pending labels Nov 17, 2025

smuzaffar reviewed Nov 17, 2025

View reviewed changes

cmsbuild added tests-approved and removed tests-started labels Nov 17, 2025

update recola cmake

df2229b

cmsbuild added tests-pending and removed tests-approved labels Nov 17, 2025

cmsbuild added tests-started and removed tests-pending labels Nov 17, 2025

cmsbuild added tests-approved and removed tests-started labels Nov 17, 2025

cmsbuild added the hold label Nov 17, 2025

smuzaffar changed the base branch from IB/CMSSW_16_0_X/master to IB/CMSSW_16_1_X/master December 18, 2025 13:46

[Sherpa] Update Sherpa to 2.2.16 and add Recola #10200

Are you sure you want to change the base?

[Sherpa] Update Sherpa to 2.2.16 and add Recola #10200

Uh oh!

Conversation

shimashimarin commented Nov 16, 2025

Uh oh!

cmsbuild commented Nov 16, 2025

Uh oh!

cmsbuild commented Nov 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

smuzaffar commented Nov 17, 2025

Uh oh!

smuzaffar Nov 17, 2025

Choose a reason for hiding this comment

Uh oh!

smuzaffar Nov 17, 2025

Choose a reason for hiding this comment

Uh oh!

shimashimarin Nov 17, 2025

Choose a reason for hiding this comment

Uh oh!

cmsbuild commented Nov 17, 2025

Comparison Summary

Uh oh!

cmsbuild commented Nov 17, 2025

Uh oh!

smuzaffar commented Nov 17, 2025

Uh oh!

cmsbuild commented Nov 17, 2025

Comparison Summary

Uh oh!

smuzaffar commented Nov 17, 2025

Uh oh!

shimashimarin commented Nov 17, 2025

Uh oh!

smuzaffar commented Nov 17, 2025

Uh oh!

makortel commented Nov 17, 2025

Uh oh!

cmsbuild commented Nov 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

cmsbuild commented Nov 16, 2025 •

edited

Loading