Fixes issues with the comments for parlay functions tabulate, map…#86
Merged
ldhulipala merged 2 commits intocmuparlay:masterfrom May 6, 2025
Merged
Fixes issues with the comments for parlay functions tabulate, map…#86ldhulipala merged 2 commits intocmuparlay:masterfrom
tabulate, map…#86ldhulipala merged 2 commits intocmuparlay:masterfrom
Conversation
…, and `delayed_tabulate`. In particular, these comments were referring to the last element of the sequence as having index `n`, when it should be `n-1`.
Contributor
Author
|
Hi, Laxman. I (think) I updated the version number as part of this pull request. |
Contributor
|
Looks like it should be good. Just have to wait for the tests! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…, and
delayed_tabulate.In particular, these comments were referring to the last element of the sequence as having index
n, when it should ben-1.