Linux build script and some platform code fixes for Linux.#60
Open
mcourteaux wants to merge 1 commit intocmuratori:mainfrom
Open
Linux build script and some platform code fixes for Linux.#60mcourteaux wants to merge 1 commit intocmuratori:mainfrom
mcourteaux wants to merge 1 commit intocmuratori:mainfrom
Conversation
…rting changes to the repetition tester to make it more readable to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a minimal PR because I was holding off on doing more, as I'd like to ask first before pouring the work in. I had some issues:
#pragma comment (lib, "....")needs the.aextension on Linux. On macOS this is again going to be different. Would be nice if there is a cleaner way to do this for all platforms at once.listing_...._linux.asmfor all the listings that need translating (all I guess, as there is the Count and Buffer argument). Or is there a more clever trick or way to do this. I was looking into symbolic registers in nasm where you could use custom register names like "count" and "pointer", and then have them preprocessor-style be filled in with either "rsi", "rdi", "rdx", "rcx", depending on the calling convention. I don't know if nasm supports such things.