Open
Conversation
- Usage message now explains both args, and does not use square brackets for non-optional args. - Only say that the test data is empty if it actually is. (My answers file was the wrong size, and that triggered the misleading "Test data size must be non-zero." error.) - Use the word "Average" instead of "Sum" in most places to describe the number computed by adding the distances together and dividing by the number of them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I got kind of confused by the error messages printed by the Haversine profiler, and had to dig into the code to understand what I did wrong. This PR makes the process smoother for the next person having similar trouble: