Skip to content

Refactor slash-commands workflow for improved clarity and security #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
riaankleinhans merged 1 commit into from
May 2, 2026
+12 −15
Merged

Refactor slash-commands workflow for improved clarity and security #388

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 12 additions & 15 deletions .github/workflows/slash-commands.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
name: Slash Commands

# Same pattern as cncf/toc/.github/workflows/slash-commands.yaml: dispatch from
# issue_comment and process via repository_dispatch in one workflow (simpler to copy
# to other repos). comment_body for processing uses the payload comment (like TOC).
# Same arrangement as cncf/toc/.github/workflows/slash-commands.yaml: dispatch on
# issue_comment, process on repository_dispatch; labeler via cncf/automation action
# reference (no checkout). Bump the SHA when `.github/actions/labeler-action` changes.

on:
issue_comment:
Expand All @@ -20,7 +20,10 @@ on:
- remove-area-command
- remove-help-command

permissions: {}
permissions:
Copy link
Copy Markdown
Contributor

@kusari-inspector kusari-inspector Bot May 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue: Move write permissions from the workflow level to the specific job level. Keep the top-level permissions block minimal (read-only) and add the required write permissions directly under the job that needs them.

Recommended Code Changes:

permissions:
  contents: read

jobs:
  dispatch-slash-command:
    name: Dispatch Slash Command
    permissions:
      issues: write
      pull-requests: write

contents: read
issues: write
pull-requests: write

concurrency:
group: slash-command-${{ github.event.issue.number || github.event.client_payload.github.payload.issue.number || github.run_id }}
Expand All @@ -29,12 +32,10 @@ concurrency:
jobs:
dispatch-slash-command:
name: Dispatch Slash Command
if: github.event_name == 'issue_comment' && github.event.comment.body
if: github.event_name == 'issue_comment'
runs-on: ubuntu-latest
permissions:
contents: read
steps:
- name: Dispatch slash commands
- name: Dispatch supported slash commands from issues and PRs
uses: peter-evans/slash-command-dispatch@9bdcd7914ec1b75590b790b844aa3b8eee7c683a # v5
with:
token: ${{ secrets.SLASH_COMMANDS_PAT }}
Expand All @@ -58,19 +59,15 @@ jobs:
name: Process Slash Command
if: github.event_name == 'repository_dispatch'
runs-on: ubuntu-latest
permissions:
contents: read
issues: write
pull-requests: write
steps:
- name: Run labeler action for issue/PR command
uses: ./.github/actions/labeler-action
uses: cncf/automation/.github/actions/labeler-action@5251ad697eb04fc7b32d05accb8aeea472164294
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
labels: https://raw.githubusercontent.com/cncf/automation/refs/heads/main/.github/labels.yaml
owner: ${{ github.event.client_payload.github.payload.repository.owner.login }}
repo: ${{ github.event.client_payload.github.payload.repository.name }}
owner: ${{ github.repository_owner }}
repo: ${{ github.event.repository.name }}
issue_number: ${{ github.event.client_payload.github.payload.issue.number }}
comment_body: ${{ github.event.client_payload.github.payload.comment.body }}
changed_files: ""