Skip to content

fix: distinguish NXDOMAIN from network errors in RDNS lookup #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cnlangzi merged 1 commit into from
Jan 11, 2026
Merged

fix: distinguish NXDOMAIN from network errors in RDNS lookup #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion bot.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,13 @@ func (b *Bot) VerifyRDNS(ipStr string) ResultStatus {
// Perform RDNS lookup
names, err := net.LookupAddr(ipStr)
if err != nil {
// Network error - allow retry, do not add to fail cache
// Distinguish network errors from NXDOMAIN (no PTR record)
if dnsErr, ok := err.(*net.DNSError); ok && dnsErr.IsNotFound {
// NXDOMAIN: PTR record does not exist - verification failed
b.fail.Add(ipStr)
return StatusFailed
}
// Network error (timeout, connection issue, etc.) - allow retry
return StatusPending
}
if len(names) == 0 {
Expand Down