Draft
Conversation
| exec { & npm run compile } | ||
| } | ||
|
|
||
| task RestoreSnippets { |
Collaborator
There was a problem hiding this comment.
Move this into the restore region
| } | ||
| } | ||
|
|
||
| task RestorePowerShellEditorServices { |
Collaborator
There was a problem hiding this comment.
Move this into the restore region
| Remove-Item .\PowerShellEditorServices -Recurse -Force -ErrorAction Ignore | ||
| Remove-Item .\Snippets -Recurse -Force -ErrorAction Ignore | ||
| Remove-Item .\out -Recurse -Force -ErrorAction Ignore | ||
| Remove-Item -Force -Recurse node_modules -ErrorAction Ignore |
Collaborator
There was a problem hiding this comment.
Nit: this Remove-Item's parameter position is messing with my ocd compared to the others lol
| [string]$EditorServicesRepoPath = $null | ||
| ) | ||
|
|
||
| #Requires -Modules @{ModuleName="InvokeBuild";ModuleVersion="3.0.0"} |
Collaborator
There was a problem hiding this comment.
I think there's a newer version we can put here
|
|
||
| #Requires -Modules @{ModuleName="InvokeBuild";ModuleVersion="3.0.0"} | ||
|
|
||
| # Grab package.json data which is used throughout the build. |
Collaborator
There was a problem hiding this comment.
It looks like we don't use these variables anywhere except to log... The logging is still useful, but maybe change this comment
Collaborator
|
Generally looks good, we can keep the copyright header for now. Just make sure you also update the README in this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First pass at creating an InvokeBuild script. Used the vscode-powershell build file as a template.
Fixes #59
One question of note: can the Copyright header be removed?