Open
Conversation
PyDictPtr is a wrapper around a TPyObjPtr that should always point to a PyDictObject (or be NULL).
bdegreve
added a commit
that referenced
this pull request
May 12, 2024
When running the test suite through CMake (by building RUN_TESTS are
make test), you don't get to see the output of the tests. You just see
something like this:
Start 1: test_io_arg_parser
1/82 Test #1: test_io_arg_parser ................. Passed 0.00 sec
Start 2: test_io_binary_stream
2/82 Test #2: test_io_binary_stream ........... ***Failed 0.00 sec
Start 3: test_io_file_attributes
3/82 Test #3: test_io_file_attributes ............ Passed 0.01 sec
This makes it hard to debug failing unittests on CI builds, where it's
hard to get to the output log files, or to rerun unittests manually.
This flag will print the output of failing tests, for easier debugging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
experimental wrapper around PyDict. Not sure about the name. Now it is PyDictPtr, but how about PyDictProxy, DictProxy.
I want to clearly distinguish it from PySequence and PyMap which in fact wrap STL containers.