Skip to content

build/github: fix processing of BES files #151931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

build/github: fix processing of BES files #151931

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions build/github/summarize-build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@ then
exit 0
fi

file $1
du -sh $1
ls -althr $1

THIS_DIR=$(cd "$( dirname "${BASH_SOURCE[0]}" )" &> /dev/null && pwd)

if [ ! -f _bazel/bin/pkg/cmd/bazci/bazel-github-helper/bazel-github-helper_/bazel-github-helper ]
Expand Down
4 changes: 4 additions & 0 deletions pkg/build/engflow/engflow.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ import (
bazelutil "github.com/cockroachdb/cockroach/pkg/build/util"
"github.com/cockroachdb/cockroach/pkg/cmd/bazci/githubpost"
"github.com/cockroachdb/cockroach/pkg/cmd/bazci/githubpost/issues"

//lint:ignore SA1019 grandfathered
gproto "github.com/golang/protobuf/proto"
"golang.org/x/net/http2"
Expand Down Expand Up @@ -114,10 +115,13 @@ func getHttpClient(certFile, keyFile string) (*http.Client, error) {
func downloadFile(client *http.Client, uri string) (string, error) {
url := strings.ReplaceAll(uri, "bytestream://", "https://")
url = strings.ReplaceAll(url, "/blobs/", "/api/v0/blob/")
fmt.Fprintln(os.Stderr, "downloading file:", url)
resp, err := client.Get(url)
if err != nil {
return "", err
}
fmt.Fprintln(os.Stderr, "file download status:", resp.StatusCode)

defer func() { _ = resp.Body.Close() }()
contents, err := io.ReadAll(resp.Body)
if err != nil {
Expand Down
Loading