pkg/kv: add tests for marshalKey and marshalValue utilities #151937
+446
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive test coverage for the marshalKey and marshalValue utility functions in the KV package. The tests validate the marshaling behavior for various data types including roachpb types, primitive types, custom types, and error conditions.
- Introduces new test file
pkg/kv/util_test.gowith 409 lines of test code - Provides extensive test coverage for both
marshalKeyandmarshalValuefunctions - Tests include validation of successful marshaling cases and error conditions
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
vishalv1994
force-pushed
the
pkg-kv-util-tests
branch
2 times, most recently
from
adc42dd to
0fcba39
Compare
vishalv1994
force-pushed
the
pkg-kv-util-tests
branch
from
0fcba39 to
c015f94
Compare
This change introduces a new test file `pkg/kv/util_test.go` that provides extensive test coverage for the `marshalKey` and `marshalValue` utility functions. The tests cover various input types including roachpb types, primitive types, custom types, and error conditions. Epic: none Release note: None
vishalv1994
force-pushed
the
pkg-kv-util-tests
branch
from
c015f94 to
1b261a8
Compare
vishalv1994
added
skipped-test
A-testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces a new test file
pkg/kv/util_test.gothat provides extensive test coverage for themarshalKeyandmarshalValueutility functions. The tests cover various input types including roachpb types, primitive types, custom types, and error conditions.Epic: none
Release note: None