-
Notifications
You must be signed in to change notification settings - Fork 4k
backup: only flush per-node progress every 15s #151950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Previously this could queue up a large number of small changes to flush, particularly if flushing was slower than updates. Now all the updates that arrive over a 15s window are rolled up before being saved. If the channel becomes full while saving, additional messages may be dropped. Release note: none. Epic: none.
bors r+ |
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating backport branch refs/heads/blathers/backport-release-24.1-151950: POST https://api.github.com/repos/dt/cockroach/git/refs: 403 Resource not accessible by integration [] Backport to branch release-24.1 failed. See errors above. error creating backport branch refs/heads/blathers/backport-release-24.3-151950: POST https://api.github.com/repos/dt/cockroach/git/refs: 403 Resource not accessible by integration [] Backport to branch release-24.3 failed. See errors above. error creating backport branch refs/heads/blathers/backport-release-25.2-151950: POST https://api.github.com/repos/dt/cockroach/git/refs: 403 Resource not accessible by integration [] Backport to branch release-25.2 failed. See errors above. error creating backport branch refs/heads/blathers/backport-release-25.3-151950: POST https://api.github.com/repos/dt/cockroach/git/refs: 403 Resource not accessible by integration [] Backport to branch release-25.3 failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Previously this could queue up a large number of small changes to flush, particularly if flushing was slower than updates, potentially causing BACKUP to hang for hours as it drains this queue (of only marginally useful information, in the case of a otherwise completed job that is just writing out the debug info).
Now all the updates that arrive over a 15s window are rolled up before being saved. If the channel becomes full while saving, additional messages may be dropped.
Release note: none.
Epic: none.