Skip to content

Conversation

dt
Copy link
Member

@dt dt commented Aug 15, 2025

Previously this could queue up a large number of small changes to flush, particularly if flushing was slower than updates, potentially causing BACKUP to hang for hours as it drains this queue (of only marginally useful information, in the case of a otherwise completed job that is just writing out the debug info).

Now all the updates that arrive over a 15s window are rolled up before being saved. If the channel becomes full while saving, additional messages may be dropped.

Release note: none.
Epic: none.

@dt dt requested a review from jeffswenson August 15, 2025 21:33
@dt dt requested a review from a team as a code owner August 15, 2025 21:33
Copy link

blathers-crl bot commented Aug 15, 2025

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@jeffswenson jeffswenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Previously this could queue up a large number of small changes to flush,
particularly if flushing was slower than updates. Now all the updates
that arrive over a 15s window are rolled up before being saved. If the channel
becomes full while saving, additional messages may be dropped.

Release note: none.
Epic: none.
@dt
Copy link
Member Author

dt commented Aug 18, 2025

bors r+

@dt dt linked an issue Aug 18, 2025 that may be closed by this pull request
@dt dt added the backport-all Flags PRs that need to be backported to all supported release branches label Aug 18, 2025
@craig
Copy link
Contributor

craig bot commented Aug 18, 2025

@craig craig bot merged commit 22f815b into cockroachdb:master Aug 18, 2025
23 checks passed
Copy link

blathers-crl bot commented Aug 18, 2025

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating backport branch refs/heads/blathers/backport-release-24.1-151950: POST https://api.github.com/repos/dt/cockroach/git/refs: 403 Resource not accessible by integration []

Backport to branch release-24.1 failed. See errors above.


error creating backport branch refs/heads/blathers/backport-release-24.3-151950: POST https://api.github.com/repos/dt/cockroach/git/refs: 403 Resource not accessible by integration []

Backport to branch release-24.3 failed. See errors above.


error creating backport branch refs/heads/blathers/backport-release-25.2-151950: POST https://api.github.com/repos/dt/cockroach/git/refs: 403 Resource not accessible by integration []

Backport to branch release-25.2 failed. See errors above.


error creating backport branch refs/heads/blathers/backport-release-25.3-151950: POST https://api.github.com/repos/dt/cockroach/git/refs: 403 Resource not accessible by integration []

Backport to branch release-25.3 failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-all Flags PRs that need to be backported to all supported release branches backport-failed target-release-25.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

backup: PerNodeProcessorProgress stalls backup completion
3 participants