cli: add lock table key support to debug decode-key #151968
Draft
+140
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
vishalv1994
added
the
E-easy
vishalv1994
force-pushed
the
cli-debug-decode-lock-table-keys
branch
from
5db84c8 to
018544f
Compare
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=95b789b1d594ac6b74f377aa7555d8d98d63240d&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
vishalv1994
force-pushed
the
cli-debug-decode-lock-table-keys
branch
from
018544f to
9f20d1c
Compare
The debug decode-key command previously only supported MVCC keys and unversioned user keys. This change adds support for decoding lock table keys by using DecodeEngineKey to determine key type and handling lock table keys with ToLockTableKey(). Test cases added for both Intent and Shared lock strengths. Fixes: cockroachdb#114425 Release Notes: None
vishalv1994
force-pushed
the
cli-debug-decode-lock-table-keys
branch
from
9f20d1c to
3759e2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The debug decode-key command previously only supported MVCC keys and unversioned user keys. This change adds support for decoding lock table keys by using DecodeEngineKey to determine key type and handling lock table keys with ToLockTableKey().
Test cases added for both Intent and Shared lock strengths.
Fixes: #114425
Release Notes: None