opt: fix trigger+computed column internal error #154789
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a bug that was caused by prematurely re-synthesizing computed columns after building a `BEFORE` trigger. Fixes cockroachdb#154672 Release note (bug fix): A bug has been fixed that caused internal errors for `INSERT .. ON CONFLICT .. DO UPDATE` statements when the target table had both a computed column and a `BEFORE` trigger. This bug has been present since triggers were introduced in v24.3.0.
|
This change is |
|
This feels a bit hacky, but gets the job done. Probably worth thinking if there is a better way to fix this. |
DrewKimball
reviewed
Oct 3, 2025
There was a problem hiding this comment.
It seems that targetCols is only used to keep track of the columns directly being inserted into or being set by an update. I think the right way to fix it is actually to have addSynthesizedComputedCols skip appending to targetCols when called for a trigger. What do you think?
I think the mutationBuilder could use some refactoring. That field is really only meant to be used "locally" while building the input for an insert or an update (and is unset after that's done), but that's not really clear from the comments.
Reviewable status:
complete! 0 of 0 LGTMs obtained
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug that was caused by prematurely re-synthesizing
computed columns after building a
BEFOREtrigger.Fixes #154672
Release note (bug fix): A bug has been fixed that caused internal errors
for
INSERT .. ON CONFLICT .. DO UPDATEstatements when the targettable had both a computed column and a
BEFOREtrigger. This bug hasbeen present since triggers were introduced in v24.3.0.