Skip to content

Conversation

msbutler
Copy link
Collaborator

@msbutler msbutler commented Oct 6, 2025

Previously, the c2c/disconnect roachtest was disconnecting two source nodes, instead of a pair of source/destination nodes. This patch fixes this bug.

Informs: #152248
Informs: #150474

Release note: none

Previously, the c2c/disconnect roachtest was disconnecting to source nodes,
instead of a pair of source/destination nodes.  This patch fixes this bug.

Informs: cockroachdb#152248
Informs: cockroachdb#150474

Release note: none
@msbutler msbutler self-assigned this Oct 6, 2025
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@msbutler msbutler added backport-all Flags PRs that need to be backported to all supported release branches backport-25.4.x Flags PRs that need to be backported to 25.4 and removed backport-25.4.x Flags PRs that need to be backported to 25.4 labels Oct 6, 2025
Copy link
Collaborator

@jeffswenson jeffswenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msbutler
Copy link
Collaborator Author

msbutler commented Oct 7, 2025

TFTR!

bors r=jeffswenson

@craig
Copy link
Contributor

craig bot commented Oct 7, 2025

Copy link

blathers-crl bot commented Oct 7, 2025

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating backport branch refs/heads/blathers/backport-release-25.3-154866: POST https://api.github.com/repos/msbutler/cockroach/git/refs: 422 Reference already exists []

Backport to branch release-25.3 failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-all Flags PRs that need to be backported to all supported release branches backport-failed target-release-26.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants