storage: mark add'l WAL latency metric essential #155395
Merged
+12
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
sumeerbhola
approved these changes
Oct 15, 2025
There was a problem hiding this comment.
@sumeerbhola reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @rmloveland)
|
thanks @sumeerbhola ! bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Oct 15, 2025
155395: storage: mark add'l WAL latency metric essential r=rmloveland a=rmloveland This change marks the `storage.wal.failover.write_and_sync.latency` metric as "Essential" so it gets automatically pulled into the 'Essential Metrics' documentation at e.g., https://www.cockroachlabs.com/docs/stable/essential-metrics-self-hosted.html#storage This is necessary since we are adding some words about this metric to the docs via cockroachdb/docs#20566 We would like to then backport this change to all supported versions of CockroachDB which have WAL failover (i.e., v24.1 and later). Addresses part of DOC-13184 Co-authored-by: Rich Loveland <rich@cockroachlabs.com>
|
Build failed: |
rmloveland
force-pushed
the
20251014-DOC-13184-storage-wal-failover-write-and-sync-latency-metric
branch
from
c0daab3 to
2f32686
Compare
This change marks the `storage.wal.failover.write_and_sync.latency` metric as "Essential" so it gets automatically pulled into the 'Essential Metrics' documentation at e.g., https://www.cockroachlabs.com/docs/stable/essential-metrics-self-hosted.html#storage This is necessary since we are adding some words about this metric to the docs via cockroachdb/docs#20566 We would like to then backport this change to all supported versions of CockroachDB which have WAL failover (i.e., v24.1 and later).
rmloveland
force-pushed
the
20251014-DOC-13184-storage-wal-failover-write-and-sync-latency-metric
branch
from
2f32686 to
84ed83f
Compare
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change marks the
storage.wal.failover.write_and_sync.latencymetric as "Essential" so it gets automatically pulled into the 'Essential Metrics' documentation at e.g.,https://www.cockroachlabs.com/docs/stable/essential-metrics-self-hosted.html#storage
This is necessary since we are adding some words about this metric to the docs via cockroachdb/docs#20566
We would like to then backport this change to all supported versions of CockroachDB which have WAL failover (i.e., v24.1 and later).
Addresses part of DOC-13184