-
Notifications
You must be signed in to change notification settings - Fork 472
Update follower reads docs with another case #19953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update follower reads docs with another case #19953
Conversation
Specifically, add the case that strong follower reads can occur under specific conditions even if you are not doing `SELECT ... AS OF SYSTEM TIME` or reading from a `GLOBAL` table.
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
Files changed: |
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify project configuration. |
@stevendanna TFTR! what other versions of CockroachDB would you expect to show this behavior? I would like to backport this change to those versions, if any |
@rmloveland I'll have to do some historical git exploration to be 100% confident since the exact set of reads eligible for follow reads has expanded a bit over time. However, my expectation is that some form of this has been available for a long time (i.e. I'm pretty sure this is the behaviour in all supported versions) |
@stevendanna Does it increase the confidence level somewhat to exclude
the v23.* versions and just focus on v24.1+?
Totally understand if the answer is still "I need to do some historical
git exploration", just don't want this PR to sit too long if not
absolutely necessary. If you're pretty confident on v24.1+ I'd be happy
to run with that.
Steven Danna ***@***.***> writes:
… *
stevendanna left a comment (cockroachdb/docs#19953)
@rmloveland I'll have to do some historical git exploration to be 100%
confident since the exact set of reads eligible for follow reads has
expanded a bit over time. However, my expectation is that some form of
this has been available for a long time (i.e. I'm pretty sure this is
the behaviour in all supported versions)
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a formatting nit
@@ -18,7 +18,7 @@ The following table summarizes the read types and how to accomplish them. | |||
| Strong Reads | Stale Reads | |||
-----|-----------|---------------------------------------------------------------- | |||
Only From Leaseholder | `SELECT` | N/A | |||
From Nearest Replica | `SELECT` on `GLOBAL` table | `SELECT` with `AS OF SYSTEM TIME <historical-timestamp-function>` | |||
From Nearest Replica | `SELECT` on a `GLOBAL` table *or* a long-running `SELECT` whose read timestamp has fallen behind the [closed timestamp]({% link {{ page.version.version }}/architecture/transaction-layer.md %}#closed-timestamps) | `SELECT` with `AS OF SYSTEM TIME <historical-timestamp-function>` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From Nearest Replica | `SELECT` on a `GLOBAL` table *or* a long-running `SELECT` whose read timestamp has fallen behind the [closed timestamp]({% link {{ page.version.version }}/architecture/transaction-layer.md %}#closed-timestamps) | `SELECT` with `AS OF SYSTEM TIME <historical-timestamp-function>` | |
From Nearest Replica | `SELECT` on a `GLOBAL` table **or** a long-running `SELECT` whose read timestamp has fallen behind the [closed timestamp]({% link {{ page.version.version }}/architecture/transaction-layer.md %}#closed-timestamps) | `SELECT` with `AS OF SYSTEM TIME <historical-timestamp-function>` |
Specifically, add the case that strong follower reads can occur under specific conditions even if you are not doing
SELECT ... AS OF SYSTEM TIME
or reading from aGLOBAL
table.