Skip to content

FK-based region-column inference #20018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 1, 2025
Merged

FK-based region-column inference #20018

merged 6 commits into from
Aug 1, 2025

Conversation

taroface
Copy link
Contributor

Copy link

netlify bot commented Jul 29, 2025

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit ad68783
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-interactivetutorials-docs/deploys/688ce3597aa5470008164ac6

Copy link

Files changed:

Copy link

netlify bot commented Jul 29, 2025

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit ad68783
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-api-docs/deploys/688ce359471f270008af6857

Copy link

netlify bot commented Jul 29, 2025

Netlify Preview

Name Link
🔨 Latest commit ad68783
🔍 Latest deploy log https://app.netlify.com/projects/cockroachdb-docs/deploys/688ce359f203470008571b3b
😎 Deploy Preview https://deploy-preview-20018--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@mw5h
Copy link

mw5h commented Jul 30, 2025

Do we need to advise customers to use --insecure? That seems orthogonal to this feature and may instill some superstition about that being required.

@dikshant
Copy link

Do we need to advise customers to use --insecure? That seems orthogonal to this feature and may instill some superstition about that being required.

We do that in a bunch of places in docs for cockroach demo so I don't see it as a huge concern. It's mostly for people to grok the feature by quickly playing around with it.

Copy link

@DrewKimball DrewKimball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mw5h
Copy link

mw5h commented Jul 30, 2025

:lgtm:

@taroface taroface requested a review from rmloveland July 31, 2025 14:46
Copy link
Contributor

@rmloveland rmloveland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, any comments are non-blocking to take or leave, mostly small style/maintenance things

@taroface taroface enabled auto-merge (squash) August 1, 2025 15:41
@taroface taroface merged commit d03b3a4 into main Aug 1, 2025
5 checks passed
@taroface taroface deleted the multi-region-auto-homing branch August 1, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants