Fix version number search discrepancy between formats #20776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve version number search by implementing context-aware filtering that distinguishes between legitimate version references and navigation spam. Previously, searches for 'v26.1' returned significantly fewer results than '26.1' due to overly aggressive version spam filtering. The fix preserves version numbers in release pages, changelogs, and complex version strings while still filtering UI navigation spam. This ensures both search formats return equivalent, relevant results. Resolves issue where version searches with 'v' prefix were less discoverable than plain number searches.
✅ Deploy Preview for cockroachdb-interactivetutorials-docs canceled.
|
✅ Deploy Preview for cockroachdb-api-docs canceled.
|
Files changed:
|
✅ Netlify Preview
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Searches for version numbers with different formats returned inconsistent results:
This discrepancy occurred because the bloat removal system was filtering standalone version
numbers like "v26.1" as "version spam," even when they appeared in legitimate documentation
contexts.
Root Cause
The existing version spam filter used a blanket approach that filtered all standalone version
numbers matching
^v\d+\.\d+(\.\d+)?(-beta\.\d+)?\s*$, regardless of context. This removedlegitimate version references from release pages while also filtering navigation spam.
Solution
Implemented context-aware version filtering that distinguishes between legitimate version
references and actual spam:
What Gets Preserved:
/releases/, release notes, changelogs)v26.1.0-beta.1)26.1) continue to work unchangedWhat Gets Filtered:
Changes
_is_version_spam()method with context-aware logicis_bloat_content()to use contextual version filteringImpact
Testing