-
Notifications
You must be signed in to change notification settings - Fork 0
new branch #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
new branch #1
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more Footnotes
|
| it('should throw error when adding duplicate user', () => { | ||
| userService.addUser(testUser); | ||
| expect(() => userService.addUser(testUser)).to.throw(); | ||
| expect(() => userService.addUser(testUser)).to.throw(`User with id ${testUser.id} already exists`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codacy has a fix for the issue: Returning a void expression from an arrow function shorthand is forbidden. Please add braces to the arrow function.
| expect(() => userService.addUser(testUser)).to.throw(`User with id ${testUser.id} already exists`); | |
| expect(() => { userService.addUser(testUser); }).to.throw(`User with id ${testUser.id} already exists`); |
| }); | ||
|
|
||
| it('should throw error when updating non-existent user', () => { | ||
| expect(() => userService.updateUser(testUser)).to.throw(`User with id ${testUser.id} not found`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codacy has a fix for the issue: Returning a void expression from an arrow function shorthand is forbidden. Please add braces to the arrow function.
| expect(() => userService.updateUser(testUser)).to.throw(`User with id ${testUser.id} not found`); | |
| expect(() => { userService.updateUser(testUser); }).to.throw(`User with id ${testUser.id} not found`); |
No description provided.