Open
Conversation
kburd
reviewed
Mar 15, 2021
Contributor
kburd
left a comment
kburd
left a comment
There was a problem hiding this comment.
Awesome work, next step is to display the data on the front end then import the data into the database
| ALTER TABLE pokemon_type ADD FOREIGN KEY(pokemon_id) REFERENCES pokemon(pokemon_id); | ||
| ALTER TABLE pokemon_type ADD FOREIGN KEY(type_id) REFERENCES types(type_id); | ||
| INSERT INTO pokemon (pokemon_id, name) | ||
| VALUES |
Contributor
There was a problem hiding this comment.
You generally don't want to include insertions in your schema, just database and table creations
| @@ -1,11 +1,24 @@ | |||
| const express = require('express') | |||
| const app = express() | |||
Contributor
There was a problem hiding this comment.
I would recommend moving this logic to rest/index.js and moving the logic there to a file named APIRouter.js
| @@ -0,0 +1,25 @@ | |||
| const mysql = require("mysql"); | |||
Contributor
There was a problem hiding this comment.
I would recommend moving this logic to the rest folder. While this file represents the persistence layer (the code who's responsible for talking to and maintaining the database) it is a service on the backend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.