feat: Revised Lesson17 bankATM simulator with full test coverage#546
Closed
Ananatawa wants to merge 2 commits intocode-differently:mainfrom
Closed
feat: Revised Lesson17 bankATM simulator with full test coverage#546Ananatawa wants to merge 2 commits intocode-differently:mainfrom
Ananatawa wants to merge 2 commits intocode-differently:mainfrom
Conversation
| @@ -0,0 +1,6 @@ | |||
| package com.codedifferently.lesson17.bank; | |||
|
|
|||
| public enum CustomerType { | |||
Contributor
There was a problem hiding this comment.
Great job using an Enum here! I’ve never seen it done this way before, but it makes perfect sense since a Customer can only be either an Individual or a Business, nothing more
Contributor
VicenteVigueras
left a comment
VicenteVigueras
left a comment
There was a problem hiding this comment.
Great job on the code! It's a positive use of AI. It would be helpful for you to revisit why you used an abstract class, inheritance, and overriding, as these OOP principles are important.
I'll close this PR now, it's a solid submission, no need for another.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finally completed my Lesson17 homework with all tests passing! Used ChatGPT a LOT to help me correct errors when tests were failing and to come up with a conventional commit message. Thanks!