feat: add money order feature for Davis lesson 17 with better organized code and all test passing#617
Closed
DavisD251 wants to merge 5 commits intocode-differently:mainfrom
Closed
feat: add money order feature for Davis lesson 17 with better organized code and all test passing#617DavisD251 wants to merge 5 commits intocode-differently:mainfrom
DavisD251 wants to merge 5 commits intocode-differently:mainfrom
Conversation
…ed code and all test passing
Contributor
VicenteVigueras
left a comment
VicenteVigueras
left a comment
There was a problem hiding this comment.
Good job on this. I noticed the SourceAccount and TargetAccount classes, it's interesting that you created them, but I didn't see them being used or integrated elsewhere in the code. So consider that if you ever re-visit this assignment.
| /** Represents a account. */ | ||
| abstract class BankAccount { | ||
|
|
||
| protected static Set<Customer> owners = null; |
Contributor
There was a problem hiding this comment.
This line looks off, this member variable shouldn't be static and should not be set to null
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.