Corey Scott TDD lab complete#11
Open
cfscott261-cell wants to merge 2 commits intocode-differently:mainfrom
Open
Corey Scott TDD lab complete#11cfscott261-cell wants to merge 2 commits intocode-differently:mainfrom
cfscott261-cell wants to merge 2 commits intocode-differently:mainfrom
Conversation
Collaborator
|
You included most of the required class features, so functionally this is close. However, the submission does not pass the build because there is a failing test. You also still need more complete test coverage for setters and validation cases. |
Author
|
Jordan,
I updated my code and my testing, I committed and pushed the code
…On Fri, Mar 20, 2026 at 11:49 AM Jordan C Eldridge ***@***.***> wrote:
*HeirJordan3* left a comment
(code-differently/tdd-lab-design-your-own-object#11)
<#11 (comment)>
You included most of the required class features, so functionally this is
close. However, the submission does not pass the build because there is a
failing test. You also still need more complete test coverage for setters
and validation cases.
—
Reply to this email directly, view it on GitHub
<#11?email_source=notifications&email_token=B5NGPMML44WHABPWIFASQJT4RVR7VA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIMBZHEYTQNBYGQ4KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#issuecomment-4099184848>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/B5NGPMMXWDRGHNX4EOFUWM34RVR7VAVCNFSM6AAAAACWNEIJ5CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DAOJZGE4DIOBUHA>
.
You are receiving this because you authored the thread.Message ID:
<code-differently/tdd-lab-design-your-own-object/pull/11/c4099184848@
github.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lab complete