Skip to content

Implemented Phone class and Junit Tests#2

Open
jayden-andrews wants to merge 2 commits intocode-differently:mainfrom
jayden-andrews:jayden-dev
Open

Implemented Phone class and Junit Tests#2
jayden-andrews wants to merge 2 commits intocode-differently:mainfrom
jayden-andrews:jayden-dev

Conversation

@jayden-andrews
Copy link
Copy Markdown

No description provided.

@HeirJordan3
Copy link
Copy Markdown
Collaborator

Nice work on this submission. Your object design is clear and the behaviors you implemented for the phone (powering on/off, charging, and using battery) are good examples of meaningful methods. Your tests also run successfully and your coverage exceeds the 80% requirement.

A few assignment requirements are still missing:
• The constructor must accept all fields as parameters. Your class has five fields but the constructor only takes four. isOn should also be included.
• The assignment requires getters and setters for every field. The class is currently missing setters for batteryLife and isOn.
• The package naming is inconsistent between your class and your test:
• object.jaydenrandrews
• object.jaydenandrews

Even though the code compiles, these should match exactly.

Overall this is a solid submission that works technically, but a few structural requirements from the assignment were not fully met.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants