Added public SteamInterface interface#152
Open
UnKabaraQuiDev wants to merge 1 commit intocode-disaster:masterfrom
Open
Added public SteamInterface interface#152UnKabaraQuiDev wants to merge 1 commit intocode-disaster:masterfrom
SteamInterface interface#152UnKabaraQuiDev wants to merge 1 commit intocode-disaster:masterfrom
Conversation
…terfaceImpl; Updated .gitignore for eclipse ide
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
com.codedisaster.steamworks.SteamInterfacewas package-private so this wasn't previously possible:I only need to reference the
dispose()method from SteamInterface:I solved it by creating my class in the package
com.codedisaster.steamworksbut this is a bit clunky and I don't like having multiple root packages in a same project.Solutions:
I renamed
SteamInterfacetoSteamInterfaceImpland kept it package-private. Created a new interfaceSteamInterfaceand implemented it inSteamInterfaceImpl, it only declares avoid dispose().Also added some javadoc