Skip to content

Added public SteamInterface interface#152

Open
UnKabaraQuiDev wants to merge 1 commit intocode-disaster:masterfrom
UnKabaraQuiDev:master
Open

Added public SteamInterface interface#152
UnKabaraQuiDev wants to merge 1 commit intocode-disaster:masterfrom
UnKabaraQuiDev:master

Conversation

@UnKabaraQuiDev
Copy link
Copy Markdown

Issue:
com.codedisaster.steamworks.SteamInterface was package-private so this wasn't previously possible:

Map<Class<? extends SteamInterface>, SteamInterface> STEAM_INTERFACES

I only need to reference the dispose() method from SteamInterface:

public static void dispose() {
	STEAM_INTERFACES.values().forEach(e -> e.dispose());
	SteamAPI.shutdown();
}

I solved it by creating my class in the package com.codedisaster.steamworks but this is a bit clunky and I don't like having multiple root packages in a same project.

Solutions:
I renamed SteamInterface to SteamInterfaceImpl and kept it package-private. Created a new interface SteamInterface and implemented it in SteamInterfaceImpl, it only declares a void dispose().

Also added some javadoc

…terfaceImpl; Updated .gitignore for eclipse ide
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant