Added EmergencyContact entity and CRUD for it#48
Open
alecstincu wants to merge 2 commits intocode4romania:developfrom
Open
Added EmergencyContact entity and CRUD for it#48alecstincu wants to merge 2 commits intocode4romania:developfrom
alecstincu wants to merge 2 commits intocode4romania:developfrom
Conversation
alecstincu
requested review from
RaduCStefanescu,
aniri,
catileptic,
georgebejan and
mihairinzis
as code owners
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/code4ro/next-door/pbg2b3zwm |
georgebejan
requested changes
Apr 1, 2020
api/src/main/java/com/code4ro/nextdoor/emergency/contact/entity/EmergencyContact.java
Outdated
Show resolved
Hide resolved
api/src/main/java/com/code4ro/nextdoor/emergency/contact/dto/EmergencyContactDto.java
Outdated
Show resolved
Hide resolved
georgebejan
approved these changes
Apr 1, 2020
vborcea
reviewed
Dec 11, 2020
| @PostMapping | ||
| @ApiOperation(value = "Saves an Emergency Contact") | ||
| public ResponseEntity<EmergencyContactDto> save(@RequestBody EmergencyContactDto emergencyContactDto) { | ||
| final EmergencyContactDto savedEmergencyContact = |
There was a problem hiding this comment.
if you device do add finals add them everywhere otherwise it's just noise
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it fix?
#31
#30
How has it been tested?
Tested locally all endpoints.