Open
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
| EXITCODE = 0 | ||
| namespace = globals().copy() | ||
| namespace.update(locals()) | ||
| namespace = globals() | locals() |
Author
There was a problem hiding this comment.
Function spy refactored with the following changes:
- Merge dictionary updates via the union operator [×2] (
dict-assign-update-to-union) - Hoist repeated code outside conditional statement [×3] (
hoist-statement-from-if) - Move assignment closer to its usage within a block (
move-assign-in-block) - Remove a redundant constructor in a dictionary union (
remove-redundant-constructor-in-dict-union) - Inline variable that is immediately returned (
inline-immediately-returned-variable)
Comment on lines
-468
to
+462
| namespace = globals().copy() | ||
| namespace.update(locals()) | ||
| namespace = globals() | locals() |
Author
There was a problem hiding this comment.
Function remove_trace refactored with the following changes:
- Merge dictionary updates via the union operator [×2] (
dict-assign-update-to-union) - Remove a redundant constructor in a dictionary union (
remove-redundant-constructor-in-dict-union)
Comment on lines
-505
to
+498
| namespace = globals().copy() | ||
| namespace.update(locals()) | ||
|
|
||
| namespace = globals() | locals() |
Author
There was a problem hiding this comment.
Function archive refactored with the following changes:
- Merge dictionary updates via the union operator [×2] (
dict-assign-update-to-union) - Remove a redundant constructor in a dictionary union (
remove-redundant-constructor-in-dict-union)
Comment on lines
-557
to
+551
| if is_mode_donotrun: | ||
| if config is not None: | ||
| if config is not None: | ||
| if is_mode_donotrun: | ||
| del modules_copy[module] | ||
| else: | ||
| if config is not None: | ||
| else: |
Author
There was a problem hiding this comment.
Function get_modules refactored with the following changes:
- Hoist nested repeated code outside conditional statements (
hoist-similar-statement-from-if)
Comment on lines
-591
to
+581
| EXITCODE = spy(active_modules) | ||
|
|
||
| # tar = arguments.tar | ||
| # if arguments.remove: | ||
| # remove_trace(active_modules) | ||
| # elif tar is not None: | ||
| # archive(active_modules, tar) | ||
|
|
||
| return EXITCODE | ||
| return spy(active_modules) |
Author
There was a problem hiding this comment.
Function main refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
This removes the following comments ( why? ):
# tar = arguments.tar
# elif tar is not None:
# remove_trace(active_modules)
# archive(active_modules, tar)
# if arguments.remove:
| @@ -32,6 +32,7 @@ | |||
| >>> filesSpy(argv=["FilesLogger.py", "filesSpy.conf"]) # (using argv) | |||
| """ | |||
|
|
|||
Author
There was a problem hiding this comment.
Lines 60-60 refactored with the following changes:
- Use previously assigned local variable (
use-assigned-variable)
|
|
||
| is_pressed = self.is_pressed | ||
| if is_pressed: | ||
| if is_pressed := self.is_pressed: |
Author
There was a problem hiding this comment.
Function KeyLogger.get_event_release refactored with the following changes:
- Use named expression to simplify assignment and conditional (
use-named-expression)
This removes the following comments ( why? ):
# code = self.get_code(event)
| @@ -23,6 +23,7 @@ | |||
| This file implements a keylogger. | |||
| """ | |||
|
|
|||
Author
There was a problem hiding this comment.
Lines 51-51 refactored with the following changes:
- Use previously assigned local variable (
use-assigned-variable)
| @@ -23,6 +23,7 @@ | |||
| This file implements a SpyWare to capture the screen. | |||
| """ | |||
|
|
|||
Author
There was a problem hiding this comment.
Lines 51-51 refactored with the following changes:
- Use previously assigned local variable (
use-assigned-variable)
| @@ -23,6 +23,7 @@ | |||
| This file implements a SpyWare to take picture with Webcam. | |||
| """ | |||
|
|
|||
Author
There was a problem hiding this comment.
Lines 51-51 refactored with the following changes:
- Use previously assigned local variable (
use-assigned-variable)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branch
mainrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
mainbranch, then run:Help us improve this pull request!