Open
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
| def get_emails(self): | ||
| uids = self.mail.uid('SEARCH', 'ALL')[1][0].split() | ||
| return uids | ||
| return self.mail.uid('SEARCH', 'ALL')[1][0].split() |
Author
There was a problem hiding this comment.
Function EmailHelper.get_emails refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
Comment on lines
-30
to
+29
| email_message = email.message_from_string(raw_email_string) | ||
| return email_message | ||
| return email.message_from_string(raw_email_string) |
Author
There was a problem hiding this comment.
Function EmailHelper.get_email_message refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
Comment on lines
-48
to
+51
| filename = uid.decode() + ".jpg" | ||
| filename = f"{uid.decode()}.jpg" | ||
| img_path = html_to_img_convertor.save_img( | ||
| html.encode(), output_dir, filename) | ||
| print(img_path) | ||
|
|
||
| filename = uid.decode() + ".pdf" | ||
| filename = f"{uid.decode()}.pdf" |
Author
There was a problem hiding this comment.
Lines 48-53 refactored with the following changes:
- Use f-string instead of string concatenation [×2] (
use-fstring-for-concatenation)
Comment on lines
-81
to
+83
| header_info = header_info + '<b>' + header + '</b>: '\ | ||
| + decoded_string + '<br/>' | ||
| header_info = f'{header_info}<b>{header}</b>: {decoded_string}<br/>' | ||
|
|
||
| return header_info + '<br/>' | ||
| return f'{header_info}<br/>' |
Author
There was a problem hiding this comment.
Function EmailtoHtml.__get_formatted_header_info refactored with the following changes:
- Use f-string instead of string concatenation [×6] (
use-fstring-for-concatenation)
Comment on lines
-92
to
+96
| hdr = "" | ||
| for element in decoded_header: | ||
| if isinstance(element[0], bytes): | ||
| hdr += str(element[0], element[1] or 'ASCII') | ||
| else: | ||
| hdr += element[0] | ||
| return hdr | ||
| return "".join( | ||
| str(element[0], element[1] or 'ASCII') | ||
| if isinstance(element[0], bytes) | ||
| else element[0] | ||
| for element in decoded_header | ||
| ) |
Author
There was a problem hiding this comment.
Function EmailtoHtml.__get_utf8_header refactored with the following changes:
- Use str.join() instead of for loop (
use-join) - Replace if statement with if expression (
assign-if-exp) - Inline variable that is immediately returned (
inline-immediately-returned-variable)
| filename = "%s_%s%s" % (file_name_parts[0], | ||
| '_' + str(counter), | ||
| file_name_parts[1]) | ||
| filename = f"{file_name_parts[0]}__{str(counter)}{file_name_parts[1]}" |
Author
There was a problem hiding this comment.
Function HtmltoImage.__get_unique_version refactored with the following changes:
- Replace interpolated string formatting with f-string (
replace-interpolation-with-fstring) - Use f-string instead of string concatenation (
use-fstring-for-concatenation) - Simplify unnecessary nesting, casting and constant values in f-strings (
simplify-fstring-formatting)
Comment on lines
-64
to
+62
| if ret_code > 0 and original_error == '': | ||
| if ret_code > 0 and not original_error: |
Author
There was a problem hiding this comment.
Function HtmltoImage.__process_errors refactored with the following changes:
- Replaces an empty collection equality with a boolean operation (
simplify-empty-collection-comparison)
| filename = "%s_%s%s" % (file_name_parts[0], | ||
| '_' + str(counter), | ||
| file_name_parts[1]) | ||
| filename = f"{file_name_parts[0]}__{str(counter)}{file_name_parts[1]}" |
Author
There was a problem hiding this comment.
Function HtmltoPdf.__get_unique_version refactored with the following changes:
- Replace interpolated string formatting with f-string (
replace-interpolation-with-fstring) - Use f-string instead of string concatenation (
use-fstring-for-concatenation) - Simplify unnecessary nesting, casting and constant values in f-strings (
simplify-fstring-formatting)
Comment on lines
-62
to
+60
| if ret_code > 0 and original_error == '': | ||
| if ret_code > 0 and not original_error: |
Author
There was a problem hiding this comment.
Function HtmltoPdf.__process_errors refactored with the following changes:
- Replaces an empty collection equality with a boolean operation (
simplify-empty-collection-comparison)
Comment on lines
-9
to
-15
| except HTTPError: | ||
| except (HTTPError, URLError, ValueError): | ||
| return False | ||
| except URLError: | ||
| return False | ||
| except ValueError: | ||
| return False | ||
|
|
Author
There was a problem hiding this comment.
Function can_url_fetch refactored with the following changes:
- Merge except handlers with identical code blocks [×2] (
merge-except-handler)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branch
masterrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
masterbranch, then run:Help us improve this pull request!