Add note about caching icons in production#31
Merged
swapnilsarwe merged 1 commit intocodeat3:mainfrom May 27, 2025
jxxe:patch-1
Merged
Add note about caching icons in production#31swapnilsarwe merged 1 commit intocodeat3:mainfrom jxxe:patch-1
swapnilsarwe merged 1 commit intocodeat3:mainfrom
jxxe:patch-1
Conversation
Contributor
|
Its mentioned in the README.md already about the caching.
But if you think having a dedicated section in every package would be helpful. Then let me update in all other 51 packages too. |
swapnilsarwe
approved these changes
May 27, 2025
Contributor
Author
|
I didn't notice that, but I think it's worth emphasizing more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I didn't realize the difference caching the icons would make. I think it would be worth mentioning in the README.
In a large Livewire app that uses a lot of icons, it shaved ~300 milliseconds off each request.