Skip to content

Make event rendering faster #2316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 2, 2025
Merged

Make event rendering faster #2316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c50cf25
perf: memoize member organiser status
mroderick Aug 27, 2025
1574621
perf: only render manage links for organisers
mroderick Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/presenters/member_presenter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
class MemberPresenter < BasePresenter
def organiser?
has_role? :organiser, :any
@organiser ||= has_role? :organiser, :any
end

def event_organiser?(event)
Expand Down
2 changes: 1 addition & 1 deletion app/views/events/_event.html.haml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
- if @user.attending?(event.__getobj__)
%span.badge.bg-success.mb-3.mb-md-0
= link_to 'Attending', event.path, class: 'text-light text-decoration-none'
- if @user.event_organiser?(event)
- if @user.organiser? && @user.event_organiser?(event)
%span.badge.bg-secondary.mb-3.mb-md-0
= link_to 'Manage', event.admin_path, class: 'text-light text-decoration-none'
.order-md-1
Expand Down
Loading