This repository was archived by the owner on Mar 29, 2023. It is now read-only.
Open
Conversation
(cherry picked from commit 9200220)
Author
|
Hello, any feedback on this? :) |
Member
|
@l3ender Thank you for the contribution. Currently we don't actively maintain this plugin. |
|
Sorry I can't commit but here the fix for retreiving emails on iOS: change the static variable allContactKeys in class CDVContacts.swift (line 45) to: change the function toDictionary in class CDVContact.swift (line 957) to: That way the find function will return emails as in the original plugin. Did only test this for find function. You may add this to this repo after more testing on other functions. Thanks for createing this repo! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms affected
What does this PR do?
This PR returns email addresses for iOS contacts.
What testing has been done on this change?
We use the
findmethod like so (transposed slightly from Ionic/Typescript)Resolves #3.