Add an optional parameter to enable generation of internal interfaces#76
Merged
ChristianSauer merged 2 commits intocodecentric:masterfrom May 2, 2025
Merged
Add an optional parameter to enable generation of internal interfaces#76ChristianSauer merged 2 commits intocodecentric:masterfrom
ChristianSauer merged 2 commits intocodecentric:masterfrom
Conversation
Comment on lines
+103
to
+110
| var generationAttribute = typeSymbol | ||
| .GetAttributes() | ||
| .FirstOrDefault(x => | ||
| x.AttributeClass != null | ||
| && x.AttributeClass.Name.Contains(AutomaticInterfaceGenerator.DefaultAttributeName) | ||
| ); | ||
|
|
||
| if (generationAttribute == null) |
Contributor
There was a problem hiding this comment.
This is a copy of the logic inside GetNameSpace:
Could you perhaps extract the attribute retrieval logic into a separate method and retrieve it once, passing it to both GetNameSpace and GetAsInternal?
Contributor
There was a problem hiding this comment.
I think I have already covered this in #77 and adding the internal logic to the GeneratedSymbolDetails should likely be pretty straight forward.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.