Skip to content

Conversation

jgonzac
Copy link

@jgonzac jgonzac commented Jun 5, 2025

Fix the case where a trailing whitespace in a preprocessor directive caused a wrong parsing because it takes the next line as the value of the definition

@jgonzac jgonzac self-assigned this Jun 5, 2025
@jgonzac jgonzac requested review from a team, alvrogd and inaki-amatria and removed request for a team June 5, 2025 14:33
Copy link
Member

@inaki-amatria inaki-amatria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jgonzac jgonzac force-pushed the feature/FixPreprocDef branch from a618a28 to 075675f Compare June 5, 2025 14:55
Copy link

@alvrogd alvrogd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upstreamable?

@jgonzac jgonzac merged commit 075675f into codee Jun 6, 2025
1 check passed
@inaki-amatria inaki-amatria deleted the feature/FixPreprocDef branch June 19, 2025 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants