Open
Conversation
bhavyaab
suggested changes
Aug 1, 2017
| .catch(err => Promise.reject(err)); | ||
| } | ||
|
|
||
| exports.deleteItem = function (schemaName, item) { |
There was a problem hiding this comment.
delete item should have property to fetch item by id; the whole item object is not supposed to pass in the request.
|
add .node_modules folder to .gitignore file so that it would not be on the repo. |
bhavyaab
reviewed
Aug 1, 2017
| }); | ||
| router.delete('/api/car', function (req, res) { | ||
| try { | ||
| var car = null; |
There was a problem hiding this comment.
the 'var car' is never get reassigned;
delete api will be called with a query parameter 'id' and other params will not be provided
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.