Skip to content

Comments

Andy David #3

Open
andyfiveeleven wants to merge 2 commits intocodefellows-seattle-301d21:masterfrom
andyfiveeleven:andy-brian
Open

Andy David #3
andyfiveeleven wants to merge 2 commits intocodefellows-seattle-301d21:masterfrom
andyfiveeleven:andy-brian

Conversation

@andyfiveeleven
Copy link

Single-line Summary

Today, Andy and David paired together. It took about 90 minutes

Reflect and summarize on your process for each TODO item :

  1. First, we started on the article JS pages. Lots of mapping and reducing, it went ok, but it was a little hard working on more complex data.
  2. Next, we modified the HTML pages considering the changes we made to the article page.
  3. Finally, we wrapped everything in iife statements.

Checklist (before submitting, fill in each set of square brackets with an 'x')

  • We have titled the Pull Request similar to our branch name (ex: 'brian-rick').
  • This PR includes commits from both myself and my partner; e.g. We followed good pair programming practices by switching driver/navigator roles.
  • There is no extraneous, unrelated code included in this PR.
  • We have summarized our TODO: process above.

// is the transformation of one collection into another. Remember that we can set variables equal to the result
// of functions. So if we set a variable equal to the result of a .map, it will be our transformed array.
// There is no need to push to anything.
rows.map(ele => Article.all.push(new Article(ele)));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since .map() returns a new array, you do not need to push items into Article.all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants