Skip to content

Comments

Allan-Jonah#4

Open
allanliebold wants to merge 10 commits intocodefellows-seattle-301d21:masterfrom
allanliebold:Allan-Jonah
Open

Allan-Jonah#4
allanliebold wants to merge 10 commits intocodefellows-seattle-301d21:masterfrom
allanliebold:Allan-Jonah

Conversation

@allanliebold
Copy link

Single-line Summary

Today, Allan and Jonah paired together. It took about 5 hours

Reflect and summarize on your process for each TODO item :

  1. First, we started by wrapping article.js and articleView.js inside IIFE functions.
  2. Next, we added NPM modules and the const string
  3. We used higher functions to get the sum of all words in all articles.
  4. We added a function to find all unique authors, then used that to filter out total words by author.
  5. Finally, we populated the stats to the DOM.

Checklist (before submitting, fill in each set of square brackets with an 'x')

  • We have titled the Pull Request similar to our branch name (ex: 'brian-rick').
  • This PR includes commits from both myself and my partner; e.g. We followed good pair programming practices by switching driver/navigator roles.
  • There is no extraneous, unrelated code included in this PR.
  • We have summarized our TODO: process above.

allanliebold and others added 9 commits June 23, 2017 16:47
… fetchAll in index.html and admin.html with the appropriate page setup methods.
…ata and instantiates new Article object stored in Article.all array
Adds conts string to connect to kilovolt database
Adds function that sums all words from all articles
Adds function to find unique authors by using a map and reduce method
Creates function to filter by author by article and total article word count
Populates author function stats results to DOM
Used li tags to format nice looking author stats
*/
// Article.all = rows.map(ele => {
// new Article(ele);
// });

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the right way to use .map()! You just need to remove the {} around the new Article(ele)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants