Skip to content
Open

Done #13

Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lab-phelan/.eslintignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
**/node_modules/*
**/vendor/*
**/*.min.js
**/coverage/*
**/build/*
26 changes: 26 additions & 0 deletions lab-phelan/.eslintrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
{
"env": {
"browser": true,
"node": true,
"commonjs": true,
"jest": true,
"es6": true
},
"globals": {
"err": true,
"req": true,
"res": true,
"next": true
},
"extends": "eslint:recommended",
"parserOptions": {
"sourceType": "module"
},
"rules": {
"no-console": "off",
"indent": [ "error", 2 ],
"quotes": ["error", "single", { "allowTemplateLiterals": true }],
"comma-dangle": ["error", "always-multiline"],
"semi": [ "error", "always" ]
}
}
80 changes: 80 additions & 0 deletions lab-phelan/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,80 @@

# Created by https://www.gitignore.io/api/node,linux

### Linux ###
*~

# temporary files which can be created if a process still has a handle open of a deleted file
.fuse_hidden*

# KDE directory preferences
.directory

# Linux trash folder which might appear on any partition or disk
.Trash-*

# .nfs files are created when an open file is removed but is still being accessed
.nfs*

### Node ###
# Logs
logs
*.log
npm-debug.log*
yarn-debug.log*
yarn-error.log*

# Runtime data
pids
*.pid
*.seed
*.pid.lock

# Directory for instrumented libs generated by jscoverage/JSCover
lib-cov

# Coverage directory used by tools like istanbul
coverage

# nyc test coverage
.nyc_output

# Grunt intermediate storage (http://gruntjs.com/creating-plugins#storing-task-files)
.grunt

# Bower dependency directory (https://bower.io/)
bower_components

# node-waf configuration
.lock-wscript

# Compiled binary addons (http://nodejs.org/api/addons.html)
build/Release

# Dependency directories
node_modules/
jspm_packages/

# Typescript v1 declaration files
typings/

# Optional npm cache directory
.npm

# Optional eslint cache
.eslintcache

# Optional REPL history
.node_repl_history

# Output of 'npm pack'
*.tgz

# Yarn Integrity file
.yarn-integrity

# dotenv environment variables file
.env


# End of https://www.gitignore.io/api/node,linux
9 changes: 9 additions & 0 deletions lab-phelan/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
In /lib, i have two .js files - both enumerate CommonJS-style modules, and pin them to 'module.exports' at the very end of the file.

In 'greet.js', per the instructions, I returned a single function, sayHi(), which appends 'hello ' to the front of a string provided by the user... and, if the user send in input other than of Type 'string', it returns 'null'.

In 'greet.js', per the instructions, I returned an Object, "Arith" with two functions within it; add() adds the two provided numbers together, and sub() subtracts them. In both functions, if either of the input values provided are not of Type 'number', I return 'null'.

Easy.

Beans.
149 changes: 149 additions & 0 deletions lab-phelan/__test__/fp.test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,149 @@
const fp = require(`../lib/fp`);

describe(`Testing suite for fp.js`, () => {

describe('fp.map()', () => {

test(`+ : "Concat Mixed Array"`, () => {
expect(fp.map(
input=>{return input + `stuff`;},
[1, 'test', null]
)).toEqual(['1stuff', 'teststuff', 'nullstuff']);
});

test(`- : "Callback not a function"`, () => {
expect (
() => {
fp.map(
'Throw : string, not function',
[1, 'test', null]
);
}
).toThrow();
});

test(`- : "Collection not an array"`, () => {
expect (
() => {
fp.map(
input=>{return input + `stuff`;},
'Throw : string, not array'
);
}
).toThrow();
});
});

describe('fp.filter()', () => {

test(`+ : "Filter Int Array"`, () => {
expect(fp.filter(
input=>{return input > 4;},
[2, 7, 2, 7, 2, 2, 7, 8, 1, 0, -1]
)).toEqual([7, 7, 7, 8]);
});

test(`- : "Callback not a function"`, () => {
expect (
() => {
fp.filter(
'Throw : string, not function',
[2, 7, 2, 7, 2, 2, 7, 8, 1, 0, -1]
);
}
).toThrow();
});

test(`- : "Collection not an array"`, () => {
expect (
() => {
fp.filter(
input=>{return input > 4;},
'Throw : string, not array'
);
}
).toThrow();
});
});

describe('fp.reduce()', () => {
test(`+ : "Sum Int Array"`, () => {
expect(fp.reduce(
(accumulator, currentValue) => {return accumulator + currentValue;},
10,
[4, 10, 15, 100, 1, 9]
)).toBe(149);
});

test(`- : "Callback not a function"`, () => {
expect (
() => {
fp.reduce(
'Throw : string, not function',
10,
[4, 10, 15, 100, 1, 9]
);
}
).toThrow();
});

test(`- : "Collection not an array"`, () => {
expect (
() => {
fp.reduce(
(accumulator, currentValue) => {return accumulator + currentValue;},
10,
'Throw : string, not array'
);
}
).toThrow();
});

test(`- : "If Collection is empty, initialState must be populated."`, () => {
expect (
() => {
fp.reduce(
(accumulator, currentValue) => {return accumulator + currentValue;},
[],
null
);
}
).toThrow();
});
});

describe('fp.slice()', () => {
test(`+ : "Slice Array"`, () => {
expect(fp.slice(
1,
5,
['4', 4, 'test', null, {}, 'okay', 110]
)).toEqual([4, 'test', null, {}]);
});

test(`- : "Collection not an Array"`, () => {
expect (
() => {
fp.slice(
1,
5,
'Throw : string, not array'
);
}
).toThrow();
});

test(`- : "Begin and End must be integers"`, () => {
expect (
() => {
fp.slice(
'Throw : string, not integer',
{},
['4', 4, 'test', null, {}, 'okay', 110]
);
}
).toThrow();
});
});

});
43 changes: 43 additions & 0 deletions lab-phelan/lib/fp.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
'use strict';

//map, filter, reduce, slice
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please delete these comments before submission


const Fp = module.exports = {};

//Map:
//Callback must be a function, Collection must be an array. Error otherwise.
Fp.map = (callback, collection) => {
if (typeof callback !== 'function') {throw new TypeError(`Argument 'callback' is not a function.`);}
if (!Array.isArray(collection)) {throw new TypeError(`Argument 'collection' is not an array.`);}
return Array.prototype.map.call(collection, callback);
};

//Filter:
//Callback must be a function, Collection must be an array. Error otherwise.
Fp.filter = (callback, collection) => {
if (typeof callback !== 'function') {throw new TypeError(`Argument 'callback' is not a function.`);}
if (!Array.isArray(collection)) {throw new TypeError(`Argument 'collection' is not an array.`);}
return Array.prototype.filter.call(collection, callback);
};

//Reduce:
//Callback must be a function, Collection must be an array. If Collection is empty, initialValue must have a value. Error otherwise.
Fp.reduce = (callback, initialState, collection) => {
if (typeof callback !== 'function') {throw new TypeError(`Argument 'callback' is not a function.`);}
if (!Array.isArray(collection)) {throw new TypeError(`Argument 'collection' is not an array.`);}
if (collection.length===0 && !initialState) {throw new Error('In Array.prototype.reduce, initialValue cannot be falsy if collection is empty.');}
return Array.prototype.reduce.call(collection, callback, initialState);
};

//Slice:
//Collection must be an Array, Begin and End must be integers. Error otherwise.
Fp.slice = (begin, end, collection) => {
if (!Array.isArray(collection)) {throw new TypeError(`Argument 'collection' is not an array.`);}

let legalTypes = ['undefined', 'number'];

if (!legalTypes.includes(typeof begin) || !legalTypes.includes(typeof end) ) {throw new Error(`In Array.prototype.slice, input values for indexes can only be nonexistent (omitted), or a number. Arguments were '${begin}' and '${end}'`);}
return Array.prototype.slice.call(collection, begin, end);
};

module.exports = Fp;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're already exporting fp on line 5, you don't need to be doing it here as well.

Loading