Skip to content

Comments

Reed Lab 02#15

Open
gagregrog wants to merge 43 commits intocodefellows-seattle-javascript-401d19:masterfrom
gagregrog:master
Open

Reed Lab 02#15
gagregrog wants to merge 43 commits intocodefellows-seattle-javascript-401d19:masterfrom
gagregrog:master

Conversation

@gagregrog
Copy link

@gagregrog gagregrog commented Nov 29, 2017

Lots of fancy schmancy tests.

Robert Reed added 30 commits November 28, 2017 14:56
directory structure establish, ignore and lint files added, directori…
6831576 
…es established, npm inited, jest added as dev dependency
added eslint dev dependency and scripts to run lint and test
d9ec56e
first test set up, failing, time to make it pass
ef9bbeb
fp.map defined, now failing because returning undefined
cf2353e
first test passing artificially with 1 expect
4d39c15
first map test failing 2nd expect
d92b682
map positive test passing both expects
becd8e3
map test passing with string input
17d591f
map test on 2nd arg fails
f51a6c2
tests passing for minimum args length
1a8946d
refactored map to ensure that empty arrays are returned, rather than …
b40e3e7 
…throwing a type error
refactored map to check explicitly for undefined, rather than falsy
64c3782
refactored map one last time to check for null or undefined as collec…
0162c6e 
…tion object. Tests still pass. Updated readme for map
added test for map to check that it is working with ES5 arguments obj…
69aee0e 
…ect and ES6 args object. Passed
filter positve test with array passes cheatily
351b380
superficially was the word I was looking for on that last commit. Pos…
b7cac47 
…itive array test now working ficially
superficially was the word I was looking for on that last commit. Pos…
b9477bb 
…itive array test now working ficially
filter test on string passes
93f3bd0
filter arguments and args positive test passing
e69bde6
test for fp.enoughParams() passing pos and neg
4fea65e
test for fp.enoughParams() passing pos and neg
abeda10
fp.enoughArgs functioning and testing properly
904148c
fp.correctType() passing pos tests
21543ec
correctType() passing pos and neg tests
a97486b
all tests still passing with correctType refactor
dcef6e0
tests for enoughArgs and correctType working with refactor, readme up…
4328b6c 
…dated to explain first four functions
tests for enoughArgs and correctType working with refactor, readme up…
e62ce93 
…dated to explain first four functions
reduce first positive test workign
92a5679
reduce positive test working with string
2e0a2df
reduce with args and arguments works
ccdd832
Robert Reed added 13 commits November 28, 2017 23:35
added tests to map and reduce to ensure all type error tests were che…
935ff6d 
…cked
reduce type errors throwing correctly, passing test
9e0448f
reduce required arguments throwing correctly, passing test
a1151c8
committing to submit current state
f7e9fd0
updated gitignore to not push node_modules or coverage folder
4ea341e
Merge pull request #1 from RobertMcReed/reed-lab-02
b32f75f 
Reed lab 02
finished reduce tests, added test for empty iterable returns in each …
252c21a 
…of map and filter and reduce
slice passes first two positives
49dc667
slice args and arguments passes
530e785
slice positive tests complete, readme updated
3fedce6
slice type error tests passing
9815691
all negative tests for slice passing
73c4c70
Merge pull request #2 from RobertMcReed/reed-lab-02
7240907 
finished up slice
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@gagregrog