Lab david#18
Open
austriker27 wants to merge 14 commits intocodefellows-seattle-javascript-401d19:masterfrom
Open
Lab david#18austriker27 wants to merge 14 commits intocodefellows-seattle-javascript-401d19:masterfrom
austriker27 wants to merge 14 commits intocodefellows-seattle-javascript-401d19:masterfrom
Conversation
izzybaer
reviewed
Dec 1, 2017
| if(typeof callback !== 'function') | ||
| throw new TypeError('<callback> should be a function!'); | ||
| return Array.prototype.slice.apply(this, [begin, end, collection]); | ||
| if(typeof callback !== 'object') |
There was a problem hiding this comment.
did changing these lines and reordering where the collection is passed change anything?
Author
There was a problem hiding this comment.
I changed it to
fp.slice = (begin, end, collection) => {
if(typeof callback !== 'object')
throw new TypeError('<collection> should be an array like object');
return Array.prototype.slice.call(collection, begin, end);
};
thinking I was checking for the wrong type but alas it throws an error. I dont think I understand where else I could pass the collection in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.