Skip to content

⚡️ Speed up function convert_sv_detections_coordinates by 15% #778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up function convert_sv_detections_coordinates by 15% #778

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions inference/core/workflows/core_steps/common/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,16 +282,14 @@ def sv_detections_to_root_coordinates(
keypoints += [shift_x, shift_y]
if detections_copy.mask is not None:
origin_mask_base = np.full((origin_height, origin_width), False)
new_anchored_masks = np.array(
[origin_mask_base.copy() for _ in detections_copy]
new_anchored_masks = np.zeros(
(len(detections_copy), origin_height, origin_width), dtype=bool
)
for anchored_mask, original_mask in zip(
new_anchored_masks, detections_copy.mask
):
for idx, original_mask in enumerate(detections_copy.mask):
mask_h, mask_w = original_mask.shape
# TODO: instead of shifting mask we could store contours in data instead of storing mask (even if calculated)
# it would be faster to shift contours but at expense of having to remember to generate mask from contour when it's needed
anchored_mask[shift_y : shift_y + mask_h, shift_x : shift_x + mask_w] = (
new_anchored_masks[idx, shift_y : shift_y + mask_h, shift_x : shift_x + mask_w] = (
original_mask
)
detections_copy.mask = new_anchored_masks
Expand Down
Loading