Skip to content

⚡️ Speed up function _get_colors_from_colormap by 443% #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up function _get_colors_from_colormap by 443% #394

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions pandas/plotting/_matplotlib/style.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,9 @@ def _get_colors_from_colormap(
) -> list[Color]:
"""Get colors from colormap."""
cmap = _get_cmap_instance(colormap)
return [cmap(num) for num in np.linspace(0, 1, num=num_colors)]
vals = np.linspace(0, 1, num=num_colors)
res = cmap(vals)
return [tuple(color) for color in res]


def _get_cmap_instance(colormap: str | Colormap) -> Colormap:
Expand All @@ -199,10 +201,10 @@ def _get_colors_from_color(
raise ValueError(f"Invalid color argument: {color}")

if _is_single_color(color):
color = cast(Color, color)
color = cast("Color", color)
return [color]

color = cast(Collection[Color], color)
color = cast("Collection[Color]", color)
return list(_gen_list_of_colors_from_iterable(color))


Expand Down