Skip to content

⚡️ Speed up function _is_floats_color by 59% #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up function _is_floats_color by 59% #397

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions pandas/plotting/_matplotlib/style.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,10 +199,10 @@ def _get_colors_from_color(
raise ValueError(f"Invalid color argument: {color}")

if _is_single_color(color):
color = cast(Color, color)
color = cast("Color", color)
return [color]

color = cast(Collection[Color], color)
color = cast("Collection[Color]", color)
return list(_gen_list_of_colors_from_iterable(color))


Expand Down Expand Up @@ -241,11 +241,14 @@ def _gen_list_of_colors_from_iterable(color: Collection[Color]) -> Iterator[Colo

def _is_floats_color(color: Color | Collection[Color]) -> bool:
"""Check if color comprises a sequence of floats representing color."""
return bool(
is_list_like(color)
and (len(color) == 3 or len(color) == 4)
and all(isinstance(x, (int, float)) for x in color)
)
if not is_list_like(color):
return False
if len(color) != 3 and len(color) != 4:
return False
for x in color:
if not isinstance(x, (int, float)):
return False
return True


def _get_colors_from_color_type(color_type: str, num_colors: int) -> list[Color]:
Expand Down