Skip to content

⚡️ Speed up method GoogleGmailDataSource.users_settings_get_pop by 8% #1039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method GoogleGmailDataSource.users_settings_get_pop by 8% #1039

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions backend/python/app/sources/external/google/gmail/gmail.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1119,11 +1119,18 @@ async def users_settings_get_pop(
Returns:
Dict[str, Any]: API response
"""
kwargs = kwargs or {}
if userId is not None:
kwargs['userId'] = userId

request = self.client.users().settings().getPop(**kwargs) # type: ignore
if not kwargs:
if userId is not None:
request = self.client.users().settings().getPop(userId=userId) # type: ignore
else:
request = self.client.users().settings().getPop() # type: ignore
else:
if userId is not None:
call_kwargs = dict(kwargs)
call_kwargs['userId'] = userId
request = self.client.users().settings().getPop(**call_kwargs) # type: ignore
else:
request = self.client.users().settings().getPop(**kwargs) # type: ignore
return request.execute()

async def users_settings_update_pop(
Expand Down