Skip to content

⚡️ Speed up method BitwardenService._create_login_item_using_server by 111% #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: main
Choose a base branch
from
+18 −8
Open

⚡️ Speed up method BitwardenService._create_login_item_using_server by 111% #121

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 18 additions & 8 deletions skyvern/forge/sdk/core/aiohttp_helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,11 @@ async def aiohttp_get_json(
raise_exception: bool = True,
retry_timeout: float = 0,
) -> dict[str, Any]:
async with aiohttp.ClientSession(timeout=aiohttp.ClientTimeout(total=timeout)) as session:
count = 0
while count <= retry:
own_session = session is None
if own_session:
session = aiohttp.ClientSession(timeout=aiohttp.ClientTimeout(total=timeout))
try:
for _ in range(retry + 1):
try:
async with session.get(
url,
Expand All @@ -88,10 +90,14 @@ async def aiohttp_get_json(
except Exception:
if retry_timeout > 0:
await asyncio.sleep(retry_timeout)
count += 1
raise Exception(f"Failed to fetch data from {url}")


finally:
if own_session:
await session.close()


async def aiohttp_get_text(
url: str,
params: dict[str, Any] | None = None,
Expand Down Expand Up @@ -139,9 +145,11 @@ async def aiohttp_post(
raise_exception: bool = True,
retry_timeout: float = 0,
) -> dict[str, Any] | None:
async with aiohttp.ClientSession(timeout=aiohttp.ClientTimeout(total=timeout)) as session:
count = 0
while count <= retry:
own_session = session is None
if own_session:
session = aiohttp.ClientSession(timeout=aiohttp.ClientTimeout(total=timeout))
try:
for _ in range(retry + 1):
try:
async with session.post(
url,
Expand All @@ -168,8 +176,10 @@ async def aiohttp_post(
except Exception:
if retry_timeout > 0:
await asyncio.sleep(retry_timeout)
count += 1
raise Exception(f"Failed post request url={url}")
finally:
if own_session:
await session.close()


async def aiohttp_delete(
Expand Down