Skip to content

⚡️ Speed up method ProphetNetTokenizer.get_vocab by 5% #882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method ProphetNetTokenizer.get_vocab by 5% #882

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/transformers/models/prophetnet/tokenization_prophetnet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,10 @@ def __init__(
" model use `tokenizer = AutoTokenizer.from_pretrained(PRETRAINED_MODEL_NAME)`"
)
self.vocab = load_vocab(vocab_file)
self.ids_to_tokens = collections.OrderedDict([(ids, tok) for tok, ids in self.vocab.items()])
# Avoid unnecessary generator overhead: use .items() directly for clarity
self.ids_to_tokens = collections.OrderedDict()
for tok, ids in self.vocab.items():
self.ids_to_tokens[ids] = tok
self.do_basic_tokenize = do_basic_tokenize
if do_basic_tokenize:
self.basic_tokenizer = BasicTokenizer(
Expand Down Expand Up @@ -374,7 +377,9 @@ def vocab_size(self):
return len(self.vocab)

def get_vocab(self):
return dict(self.vocab, **self.added_tokens_encoder)
# Use dict unpacking instead of dict() for slightly better performance and clarity
# (self.vocab already an OrderedDict)
return {**self.vocab, **self.added_tokens_encoder}

def _tokenize(self, text):
split_tokens = []
Expand Down