Skip to content

⚡️ Speed up method ProphetNetTokenizer._convert_token_to_id by 417% #884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method ProphetNetTokenizer._convert_token_to_id by 417% #884

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/transformers/models/prophetnet/tokenization_prophetnet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,6 +354,11 @@ def __init__(
)
self.wordpiece_tokenizer = WordpieceTokenizer(vocab=self.vocab, unk_token=str(unk_token))

# Cache unknown token id for use in _convert_token_to_id
self._unk_token_id = self.vocab.get(
self.unk_token if hasattr(self, "unk_token") and self.unk_token is not None else unk_token
)

super().__init__(
do_lower_case=do_lower_case,
do_basic_tokenize=do_basic_tokenize,
Expand Down Expand Up @@ -391,7 +396,11 @@ def _tokenize(self, text):

def _convert_token_to_id(self, token: str):
"""Converts a token (str) in an id using the vocab."""
return self.vocab.get(token, self.vocab.get(self.unk_token))
# Optimize the fallback by caching unk id in __init__ to avoid repeated dictionary lookups
id_ = self.vocab.get(token)
if id_ is not None:
return id_
return self._unk_token_id

def _convert_id_to_token(self, index: int):
"""Converts an index (integer) in a token (str) using the vocab."""
Expand Down