Skip to content

Update panel state of DataContainer when custom filters are active#244

Merged
fritzmg merged 4 commits intocodefog:mainfrom
fritzmg:bugfix/update-filter-panel-state
Jan 30, 2026
Merged

Update panel state of DataContainer when custom filters are active#244
fritzmg merged 4 commits intocodefog:mainfrom
fritzmg:bugfix/update-filter-panel-state

Conversation

@fritzmg
Copy link
Collaborator

@fritzmg fritzmg commented Jan 29, 2026

As noted in contao/contao#9325 if a filter is active that is added by Haste via the panel_callback, Contao 5.6+ does not make the Reset button available, because it does not know that a filter is active. For example, if you install codefog/contao-news_categories and then filter the news by categories in the back end, you cannot use the Reset button to undo the filter (unless you have a "standard" filter also active).

This is because Haste currently does not report the panel state back to the DataContainer instance. This PR fixes that.

@fritzmg fritzmg self-assigned this Jan 29, 2026
@fritzmg fritzmg added the bug label Jan 29, 2026
@fritzmg fritzmg marked this pull request as draft January 29, 2026 11:06
@fritzmg fritzmg marked this pull request as ready for review January 29, 2026 12:37
@fritzmg
Copy link
Collaborator Author

fritzmg commented Jan 29, 2026

Note

This PR now adds auto submission of the <select> for Contao 5.6+. While Contao 5.6 does not use auto submission yet, it is EoL soon so I think it does not matter.

@fritzmg fritzmg merged commit f41afa1 into codefog:main Jan 30, 2026
7 checks passed
@fritzmg fritzmg deleted the bugfix/update-filter-panel-state branch January 30, 2026 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants