[김혜연] Sprint Mission 11#264
Merged
JiNookk merged 2 commits intocodeit-bootcamp-nodejs:김혜연from Dec 3, 2025
Hidden character warning
The head ref may contain hidden characters: "\uae40\ud61c\uc5f0"
Merged
Conversation
JiNookk
approved these changes
Dec 3, 2025
Collaborator
JiNookk
left a comment
JiNookk
left a comment
There was a problem hiding this comment.
수고하셨습니다~ 코멘트 한번만 확인 부탁드려요!
| @@ -0,0 +1,2 @@ | |||
| node_modules | |||
Collaborator
There was a problem hiding this comment.
현재 .env 파일이 제외되지 않아 Docker 이미지에 환경 변수 파일이 포함될 수 있습니다. 보안을 위해 반드시 .env를 추가해주세요.
| @@ -0,0 +1,16 @@ | |||
| FROM node:20 | |||
Collaborator
There was a problem hiding this comment.
현재 단일 스테이지로 구성되어 있어 최종 이미지에 개발 의존성과 소스 코드가 모두 포함됩니다. 멀티 스테이지 빌드를 적용해 주세요!
| depends_on: | ||
| - db | ||
|
|
||
| postgres: |
Collaborator
There was a problem hiding this comment.
로컬 개발 환경에서 DB 접속이 필요할 경우를 위해 포트 매핑을 추가하는 것이 좋을 것 같아요!
| context: ./mission9 | ||
| file: ./Dockerfile | ||
| push: true | ||
| tags: ${{ secrets.DOCKERHUB_USERNAME }}/express-app:latest |
Collaborator
There was a problem hiding this comment.
Dockerhub를 이용해서 cd파이프 라인 잘 구현하셨네요!
Collaborator
There was a problem hiding this comment.
버전 추적을 용이하게 하려면 github.sha활용해서 버전 태깅 넣어보시는것도 추천드릴게요!
| POSTGRES_USER: user_mbti | ||
| POSTGRES_PASSWORD: pw_mbti | ||
|
|
||
| volumes: |
Collaborator
There was a problem hiding this comment.
Named Volume을 사용하여 데이터 영속성을 보장한 점이 좋습니다~
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
요구사항
Github Actions 활용
Docker 이미지 만들기
멘토에게