[전범주] Sprint Mission 12#283
Merged
chemonoworld merged 131 commits intocodeit-bootcamp-nodejs:algorithm-전범주from Feb 9, 2026
Merged
[전범주] Sprint Mission 12#283chemonoworld merged 131 commits intocodeit-bootcamp-nodejs:algorithm-전범주from
chemonoworld merged 131 commits intocodeit-bootcamp-nodejs:algorithm-전범주from
Conversation
Collaborator
intwocave
commented
Jan 21, 2026
intwocave
commented
- 선택 정렬 (Selection sort)
- 숫자형 배열을 파라미터로 받고, 해당 배열을 수정하도록 구현합니다.
- 삽입 정렬 (Insertion sort)
- 숫자형 배열을 파라미터로 받고, 해당 배열을 수정하도록 구현합니다.
- 병합 정렬 (Merge sort)
- 숫자형 배열을 파라미터로 받고, 정렬된 새로운 배열을 리턴하도록 구현합니다.
- 퀵 정렬 (Quick sort)
- 숫자형 배열을 파라미터로 받고, 해당 배열을 수정하도록 구현합니다.
intwocave
force-pushed
the
algorithm
branch
2 times, most recently
from
a954515 to
49bb5d0
Compare
Collaborator
|
미션 10, 11 코드들이 있어서 너무 코드 리뷰가 어렵습니다. 기준 브랜치에서 체크아웃해서 새로운 깔끔한 브랜치를 만들어내는게 좋습니다. |
chemonoworld
reviewed
Feb 9, 2026
| let i = 0, | ||
| j = 0; | ||
|
|
||
| while (i < l.length || j < r.length) { |
Collaborator
There was a problem hiding this comment.
보통은 두 배열에 요소가 모두 있을 때까지 while을 돌리고, 남은 요소들을 concat이나 개별 while 문으로 합치는 방식을 쓰긴하거든요. 자바스크립트 있는 쪽의 undefined 특성을 이용하는건 좋은데 저는 개인적으로 가독성과 간결함때문에 선호하지 않는 방식이긴 합니다.
Collaborator
|
로직 구현 자체는 흠 잡을 곳 없이 훌륭합니다. |
chemonoworld
merged commit bbf435f
into
codeit-bootcamp-nodejs:algorithm-전범주
2 of 4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.