refactor(one-dark): export all theme colors for reuse is needed#3
Open
bRRRITSCOLD wants to merge 5 commits intocodemirror:mainfrom
Open
refactor(one-dark): export all theme colors for reuse is needed#3bRRRITSCOLD wants to merge 5 commits intocodemirror:mainfrom
bRRRITSCOLD wants to merge 5 commits intocodemirror:mainfrom
Conversation
Author
|
@marijnh If you have some time - I just want to reuse the theme color for some things in an app, don't want to use a forked version or keep local colors up to date with this repo |
…and export additions/changes
Member
|
Author
|
Author
|
Member
You're the one who moved it to version 7.0.0. I'm not talking about automated tests. I'm talking about the fact that you're using CSS properties like |
Author
|
As for |
marijnh
added a commit
that referenced
this pull request
Aug 4, 2022
FEATURE: Export a `color` object holding the colors used in the theme. Issue #3
Member
|
Would attached patch work as a replacement for this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Export theme colors for reuse by down stream users to match said theme colors/reuse of said theme colors